Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test case in question-232 #1212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhzhch335
Copy link

In question 232,we need change add key modifiers made this will fire even if Alt or Shift is also pressed. But in the test case of question 232, if we passed the case

await buttons[0].trigger('click.alt')
expect(printLog).toMatchInlineSnapshot('"onClick1"')

printLog can't be empty, so that the case will always be passed until the next time to call console.log.
So even if the answer only writes alt key modifer like this:

<button @click.alt="onClick1">A</button>

it's still passed.

Futhermore, there isn't a case includes Alt and Shift are pressed at the same time, I added.

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for vuejs-challenges ready!

Name Link
🔨 Latest commit ede82af
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-challenges/deploys/634273349599650008f962a1
😎 Deploy Preview https://deploy-preview-1212--vuejs-challenges.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant