Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more generic deployment key mappings #128

Open
mpdude opened this issue Sep 1, 2022 · 0 comments
Open

Support more generic deployment key mappings #128

mpdude opened this issue Sep 1, 2022 · 0 comments

Comments

@mpdude
Copy link
Member

mpdude commented Sep 1, 2022

As described in https://github.com/webfactory/ssh-agent#support-for-github-deploy-keys, this action supports giving GitHub repository URLs in SSH key comments.

It will then configure git to replace different variants of how the repo can be specified with an URL pointing to a made-up hostname.

This hostname will cause dedicated SSH config to be selected, which maps back to the right github.com hostname while selecting a particular SSH key to use.

All this was written with only github.com URLs in mind, since we have a fairly good understanding of how these URLs are made up, and we know about the different variants (including the https:// scheme) that we can safely rewrite.

Now, different requests have been made to support either repo URLs outside of github.com (possibly self-hosted GitHub Enterprise), or being able to use key comments to map keys not to repositories, but whole GitHub organisations.

In general, I'd be open to support this, but we would need to find patterns that cover a sufficiently broad range of repo URLs, figure out how flexible/generic the Git .insteadof configuration can/needs to be and how to avoid this becoming a maintenance burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant