Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not match GitHub URL pattern. It's not working on enterprise github with two private repos #112

Closed
ZhUyU1997 opened this issue Apr 14, 2022 · 4 comments

Comments

@ZhUyU1997
Copy link

I tried to config two private keys on enterprise Github.
But something is wrong with it.

Comment for (public) key 'ssh-ed25519 [email protected]:aaaa.git' does not match GitHub URL pattern. Not treating it as a GitHub deploy key.
Comment for (public) key 'ssh-ed25519 [email protected]:bbbb.git' does not match GitHub URL pattern. Not treating it as a GitHub deploy key.

Can we support config Github hostname?

Thanks,
Yu Zhu

@Smarker
Copy link

Smarker commented Aug 31, 2022

This issue is also super similar to #123

@mpdude
Copy link
Member

mpdude commented Sep 1, 2022

This issue is also super similar to #123

To my understanding, #123 is about an unnecessary (meaningless) log output line due to a parsing glitch.

@mpdude
Copy link
Member

mpdude commented Sep 1, 2022

Yes. The problem is that we need to recognize the different repo names, set up fake hostnames for them, then map those back to the right ones while specifying the key in the SSH config and finally make git rewrite differnt variants of the original URL to the replacement hosts... 🥴.

If anyone comes up with a good suggestion how to make this work for repo URLs in general (i. e. not limited to the [email protected]/org/repo pattern), I'd be happy to discuss that!

@mpdude
Copy link
Member

mpdude commented Sep 1, 2022

There are duplicate reports for this. I've created #128 to focus the discussion in one issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants