Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

(WIP) Upgrade wdio-sync to support node@12 #156

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

renfeng
Copy link
Contributor

@renfeng renfeng commented Jun 5, 2019

fiber@4, a dependency of wdio-sync, is required. See laverdet/node-fibers#409

fiber@4, a dependency of wdio-sync, is required. See laverdet/node-fibers#409
@jsf-clabot
Copy link

jsf-clabot commented Jun 5, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package version doesn't exist

@pathmapper
Copy link

Ref #155

@renfeng
Copy link
Contributor Author

renfeng commented Jun 6, 2019

this package version doesn't exist

Sorry that I didn't test it properly before making the pull request. Will push more chance. Hold on.

@renfeng renfeng changed the title Upgrade wdio-sync to support node@12 (WIP) Upgrade wdio-sync to support node@12 Jun 6, 2019
@renfeng
Copy link
Contributor Author

renfeng commented Jun 6, 2019

Now the unit tests fail with TypeError: _get__(...) is not a function

@renfeng
Copy link
Contributor Author

renfeng commented Jun 6, 2019

Downgraded @wdio/sync to 5.8.0 the first version introduced fibers@4. Hope that would bring the gap between [email protected] a little closer...

Can you take a look and fix the failing unit tests? Thanks.

@christian-bromann
Copy link
Contributor

@renfeng @wdio/sync is for v5 and not v4 (where we use wdio-sync)

@renfeng
Copy link
Contributor Author

renfeng commented Jun 6, 2019

@renfeng @wdio/sync is for v5 and not v4 (where we use wdio-sync)

Thanks for pointing it out! Then we'll have to wait for the next release version of wdio-sync.
See their fix, webdriverio-boneyard/wdio-sync#136

@christian-bromann
Copy link
Contributor

Thanks for pointing it out! Then we'll have to wait for the next release version of wdio-sync.

I would recommend to upgrade to WebdriverIO v5

@pathmapper
Copy link

I would recommend to upgrade to WebdriverIO v5

@christian-bromann so v4 is not maintained anymore and there will be no new releases? I did not find any information on this matter.

@christian-bromann
Copy link
Contributor

there will be no new releases?

There will, but people haven't had the chance to make that release. Anyway I urgently recommend to move to v5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants