Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API update: input argument renaming and potentially expansion of allowed input #786

Merged
merged 1 commit into from
Mar 9, 2023
Merged

API update: input argument renaming and potentially expansion of allowed input #786

merged 1 commit into from
Mar 9, 2023

Conversation

albertopeam
Copy link
Contributor

@albertopeam albertopeam commented Feb 26, 2023 •
edited by JeneaVranceanu
Loading

Summary of Changes

Closes #787
Based on #731

Having doubts about creating doc

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@albertopeam
Copy link
Contributor Author

@JeneaVranceanu could you take a look and review if point 1 of the issue #731 is correctly done?

@JeneaVranceanu
Copy link
Collaborator

@albertopeam Yes, looks right. Thanks!
I'll open a separate issue that will focus only on renaming options to transaction and we will be able to merge this PR.

@JeneaVranceanu JeneaVranceanu mentioned this pull request Feb 28, 2023
Open
@JeneaVranceanu
Copy link
Collaborator

Done.

@albertopeam albertopeam marked this pull request as ready for review March 1, 2023 22:21
@JeneaVranceanu JeneaVranceanu merged commit 318f8da into web3swift-team:develop-4.0 Mar 9, 2023
@albertopeam albertopeam deleted the feature/api-update-options-to-transaction branch March 16, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janndriessen janndriessen janndriessen approved these changes

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

@yaroslavyaroslav yaroslavyaroslav Awaiting requested review from yaroslavyaroslav

Assignees
No one assigned
Labels
4.0
Projects
Web3Swift 4.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertopeam @JeneaVranceanu @janndriessen