New ChirpRadio connector #4695
Closed
New ChirpRadio connector #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaccarmac
added
minor-change
inverse
requested changes
May 13, 2024
src/core/connectors.ts
Outdated
| /** | ||
| * true if website has its own scrobbling system the user needs to be aware of. | ||
| */ | ||
| hasNativeScrobbler?: true; |
There was a problem hiding this comment.
This file looks like it needs to be adapted to only the addition of the connector addition
|
@inverse I just pushed over the change to connectors.ts |
|
@jbwharris looks like there are still a lot of changes that shouldnt be there 🤔 |
|
@inverse I have no idea what I've done wrong with this one. I'm going to create a new branch and do a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New connector for https://chirpradio.org