Fix piped.ts (connector)

[Tamarindo94]

Fixed piped connector by ditching querySelector, which often returned null. Util.getAttrFromSelectors is now used instead

UPDATE: Util.getAttrFromSelectors wasn't the correct solution - querySelector is still used, but now the connector avoids trying to access properties on null objects that are querySelected before the video is added to the DOM (which was the reason for the connector crashing)

[inverse]

Thanks for the contribution!

Looks like there are some linting issues with this change though :/

[Tamarindo94]

Hope it's ok now

[inverse]

Would using the ?. operator be a more concice way of expressing this work?

Connector.getCurrentTime = () => (document.querySelector('.shaka-video') as HTMLVideoElement)?.currentTime;

[Tamarindo94]

It should be, yes. I wasn't sure whether the ?. operator was discouraged by the project guidelines so I opted for the more verbose version. The only difference is that, with the ?. operator, undefined will be returned if querySelector doesn't find the element, while the verbose version explicitly returns null in such case, and I don't know if that makes a difference to the core. If it doesn't, they should be functionally equivalent

[inverse]

I think we can handle undefined as per the base implementation.

public getCurrentTime: () => number | null | undefined;

But also happy to leave it as is 👍

[inverse]

Looks like there is one linting issue to fix which prettier . --check should show.

[Tamarindo94]

I'd really like to fix it but I have no clue on how to do that...

[inverse]

If you run npx prettier . --write it should fix the issues automatically

[inverse]

Suggested change

	const videoEl = (document.querySelector('.shaka-video') as HTMLVideoElement);
	const videoEl = document.querySelector('.shaka-video') as HTMLVideoElement;

[inverse]

Suggested change

	const videoEl = (document.querySelector('.shaka-video') as HTMLVideoElement);
	const videoEl = document.querySelector('.shaka-video') as HTMLVideoElement;