Add 'Like' selector for youtube music #4548
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looked at niconico a bit. It is changing the icon, so i looked into how this is done and it seems it is updating xlink:href of use element in svg to point to new ID. |
yayuyokitano
added
new-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses the issue, but for youtube music: #4536
Describe the changes you made
Added a 'Like' selector for Youtube Music.
Additional context
I tried doing the same with Niconico but the selectors aren't helpful and using different selectors to get a normal Love/Unlove response did not work. For example:
For now, I need to think about Niconico but it doesn't seem like there aren't any good, simple UI methods.