Add infobox menu #4494
Open
Add infobox menu #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayuyokitano
added
new-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR: currently functional, but needs some refactoring and UI needs some cleanup visually.
Adds a menu to infobox, and makes some changes to connector API to reflect this.
This allows user to edit track, skip track, enable/disable connector, and disable the infobox itself on the website as they're scrobbling.
Especially convenient on mobile.
Since we are injecting straight into website, we do not use any framework, html, or css here, just pure typescript.
Editing is done through just creating an iframe to extension popup (regular popup cannot be programmatically opened in chromium, so this is a workaround).
Moves all the infobox logic out to src/ui/inject/infobox.ts
Closes #4432