Make transform property parse not trip up at !important. #46280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5538019
branch
from
6e1f1fd
to
4b8306e
Compare
After recent parser changes, every property needs to be able to break cleanly on an unexpected token, such as !important. Transform was inadvertently missed (except for the case of “none”), so fix that. Fixed: 340100643 Change-Id: I45521e331090c5d554218726a9b260b584014940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538019 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Steinar H Gunderson <[email protected]> Auto-Submit: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1301278}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5538019
branch
from
4b8306e
to
391fd4b
Compare
wpt-pr-bot
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent parser changes, every property needs to be able to
break cleanly on an unexpected token, such as !important. Transform
was inadvertently missed (except for the case of “none”), so fix that.
Fixed: 340100643
Change-Id: I45521e331090c5d554218726a9b260b584014940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5538019
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Steinar H Gunderson <[email protected]>
Auto-Submit: Steinar H Gunderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301278}