Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the docker image from the GitHub registry #46279

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use the docker image from the GitHub registry #46279

wants to merge 4 commits into from

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented May 15, 2024 •
edited

Closes #28903

@OrKoN OrKoN requested a review from foolip May 15, 2024 09:52
@OrKoN OrKoN closed this May 16, 2024
@OrKoN OrKoN reopened this May 16, 2024
@OrKoN OrKoN force-pushed the orkon/test-docker branch 4 times, most recently from 0d05104 to e2e0d0b Compare May 17, 2024 10:28
@OrKoN OrKoN changed the title Test the docker image from the GitHub registry Use the docker image from the GitHub registry May 17, 2024
@OrKoN
Copy link
Contributor Author

OrKoN commented May 17, 2024

The tools unit tests failure already exists on the main branch (PR to reproduce the issue #46348).

@OrKoN OrKoN marked this pull request as ready for review May 17, 2024 13:51
jgraham
jgraham requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think actually merging this probably requires an RFC in case anyone is depending on the images in some other workflow.

tools/docker/README.md Outdated Show resolved Hide resolved
@jgraham
Copy link
Contributor

jgraham commented May 17, 2024

do we need the local scripts in tools/docker/frontend.py? or is it sufficient to use the GitHub Actions workflow?

Yes, that's extremely useful for using the docker image locally, particularly when experimenting with changes to the image itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham requested changes

@foolip foolip Awaiting requested review from foolip

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

Requested changes must be addressed to merge this pull request.

Assignees

@DanielRyanSmith DanielRyanSmith

Labels
ci docker infra Taskcluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DockerHub webplatformtests org limited to 3 members
4 participants
@OrKoN @jgraham @wpt-pr-bot @DanielRyanSmith