Add allow unload=* to allowlist for frameset frames. #46271
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5540810
branch
from
020dee8
to
4f0f120
Compare
With unload deprecation, it becomes impossible to use unload in `<frame>`s because there is no way to set an `allow` attribute on them. This change adds an `unload=*` to their allowlist, meaning that unload will be allowed if it's allowed in the parent and the child sets the correct Permissions-Policy header. Bug: 40286851 Change-Id: I593786ae88683986c740800848de7bfa6a364dd3
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5540810
branch
from
4f0f120
to
9f1b1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With unload deprecation, it becomes impossible to use unload in
\<frame>s because there is no way to set anallowattribute onthem. This change adds an
unload=*to their allowlist, meaning thatunload will be allowed if it's allowed in the parent and the child
sets the correct Permissions-Policy header.
Bug: 40286851
Change-Id: I593786ae88683986c740800848de7bfa6a364dd3
Reviewed-on: https://chromium-review.googlesource.com/5540810
WPT-Export-Revision: e77c093046051c94b60d07adb10e80600705087d