Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support framesets and frames in remove-context-helper. #46270

Merged
merged 1 commit into from
May 17, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 15, 2024

I need to test unload deprecation's interaction with framesets.

Bug: 40286851
Change-Id: I3f53d73e5c663b447a238a1ca7497064b9c96ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541148
Commit-Queue: Domenic Denicola <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Auto-Submit: Fergal Daly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301100}

I need to test unload deprecation's interaction with framesets.

Bug: 40286851
Change-Id: I3f53d73e5c663b447a238a1ca7497064b9c96ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541148
Commit-Queue: Domenic Denicola <[email protected]>
Reviewed-by: Domenic Denicola <[email protected]>
Auto-Submit: Fergal Daly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301100}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@WeizhongX
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test | Subtest | Results | Messages -- | -- | -- | -- /html/browsers/browsing-the-web/history-traversal/document-state.https.html |   | OK: 2/10, TIMEOUT: 8/10 |   /html/browsers/browsing-the-web/history-traversal/document-state.https.html | A navigation's initiator origin and referrer are stored in the document state and used on location.reload() | PASS: 2/10, TIMEOUT: 8/10 | Test timed out

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@WeizhongX
Copy link
Contributor

@KyleJu KyleJu merged commit d213c42 into master May 17, 2024
16 of 18 checks passed
@KyleJu KyleJu deleted the chromium-export-cl-5541148 branch May 17, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants