Rename position-anchor:implicit to position-anchor:auto #46269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5540275
branch
from
9042634
to
9539feb
Compare
This was resolved here: w3c/csswg-drafts#10312 (comment) and will be added to the spec shortly. This is observable, but barely. After this CL, `implicit` won't be a valid value for `position-anchor`, so it'll resolve to the default value of `auto`. Meaning the behavior will be the same. But via the CSSOM, getComputedStyle(element).positionAnchor will now return "auto" instead of "implicit". Fixed: 340206288 Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540275 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1301585}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5540275
branch
from
9539feb
to
05d3f03
Compare
wpt-pr-bot
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was resolved here:
w3c/csswg-drafts#10312 (comment)
and will be added to the spec shortly.
This is observable, but barely. After this CL,
implicitwon't be avalid value for
position-anchor, so it'll resolve to the defaultvalue of
auto. Meaning the behavior will be the same. But via theCSSOM, getComputedStyle(element).positionAnchor will now return "auto"
instead of "implicit".
Fixed: 340206288
Change-Id: I75b05310638dca70aa6aa8807da8cfe7c9624a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540275
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1301585}