Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: path join #8895

Closed
wants to merge 4 commits into from
Closed

fix: path join #8895

wants to merge 4 commits into from

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 30, 2024

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Dec 30, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 060d6a6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6772a0b2ac8cc200083eba1f

@SyMind SyMind changed the title feat: path join fix: path join Dec 30, 2024
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) and removed release: feature release: feature related release(mr only) labels Dec 30, 2024
@SyMind SyMind force-pushed the fix-path-join branch 4 times, most recently from e86c2e5 to 6ee8d07 Compare December 30, 2024 13:09
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8895 will not alter performance

Comparing fix-path-join (060d6a6) with main (28f2169)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@SyMind SyMind closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz will be requested when the pull request is marked ready for review jerrykingxyz is a code owner

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SyMind