-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: handle glob patterns ending with /** in CopyRspackPlugin #8803
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #8803 will not alter performanceComparing Summary
|
if the glob library behaves different from webpack's glob library, maybe we should consider align glob crate behavior to globby, I'm not sure the BTW this is actually a breaking and should be emphasized in notice |
Yes, it aligns with the glob pattern used by see https://github.com/shulaoda/fast-glob/blob/2fa17673ba4ba599a7ad21221867dc71557be68b/tests/test.rs#L8 |
Okay, sometimes it's hard to distinguish between fixing and breaking. I'll revise the corresponding description later to emphasize that. |
@shulaoda |
yeah this is tricky maybe we should have some label like “alignment breaking” which means the small |
Yes, |
Summary
Attention: This PR includes a breaking change, but it is necessary to align with webpack's behavior.
fix #8801
A glob pattern ending with /** should match all files within a directory, not just the directory itself.
Since the standard glob only matches directories (refer to rust-lang/glob#129), we append /* to align with webpack's behavior.
Checklist