Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: merge binding crates into rspack_binding_values #8761

Merged
merged 1 commit into from
Dec 18, 2024
Merged

refactor: merge binding crates into rspack_binding_values #8761

merged 1 commit into from
Dec 18, 2024

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Dec 18, 2024

Summary

Remove rspack_binding_options

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 18, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 18, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e17329c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6762743dfad3710008931371

ahabhgk
ahabhgk previously approved these changes Dec 18, 2024
View reviewed changes
@h-a-n-a h-a-n-a force-pushed the merge-binding-crates branch from 856ac99 to 5659b25 Compare December 18, 2024 06:37
@h-a-n-a h-a-n-a force-pushed the merge-binding-crates branch from e5acd2f to e17329c Compare December 18, 2024 07:05
@h-a-n-a h-a-n-a merged commit 8aeb507 into main Dec 18, 2024
32 checks passed
@h-a-n-a h-a-n-a deleted the merge-binding-crates branch December 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@h-a-n-a h-a-n-a

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @ahabhgk