Skip to content

Commit

Permalink
test: fix some unstable test cases for layer stats (#8453)
Browse files Browse the repository at this point in the history 
fix(test): fix some tests error for layer stats
  • Loading branch information
@easy1090
easy1090 authored Nov 17, 2024
1 parent 1ca6b68 commit 9112e35
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/rspack-test-tools/tests/__snapshots__/StatsAPI.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1659,6 +1659,8 @@ Object {
modules: Array [
Object {
children: Array [],
issuer: ,
issuerName: ,
layer: test,
size: 304,
sizes: Object {
Expand All @@ -1668,6 +1670,8 @@ Object {
},
Object {
children: Array [],
issuer: ,
issuerName: ,
layer: legacy,
size: 304,
sizes: Object {
Expand Down
2 changes: 2 additions & 0 deletions packages/rspack-test-tools/tests/statsAPICases/layer-stats.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ module.exports = {
};
const statsData = stats?.toJson(options);
statsData.modules.forEach(mod => {
mod.issuer = '';
mod.issuerName = '';
mod.children = [];
});

Expand Down

2 comments on commit 9112e35

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-11-17 1ca6b68) Current Change
10000_big_production-mode + exec 44.1 s ± 616 ms 44.5 s ± 680 ms +0.93 %
10000_development-mode + exec 1.81 s ± 34 ms 1.78 s ± 32 ms -1.63 %
10000_development-mode_hmr + exec 645 ms ± 11 ms 639 ms ± 7.1 ms -0.82 %
10000_production-mode + exec 2.41 s ± 28 ms 2.42 s ± 36 ms +0.19 %
arco-pro_development-mode + exec 1.78 s ± 61 ms 1.8 s ± 48 ms +0.95 %
arco-pro_development-mode_hmr + exec 430 ms ± 0.46 ms 431 ms ± 1.9 ms +0.06 %
arco-pro_production-mode + exec 3.2 s ± 102 ms 3.18 s ± 68 ms -0.76 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.22 s ± 63 ms 3.21 s ± 73 ms -0.38 %
threejs_development-mode_10x + exec 1.59 s ± 14 ms 1.58 s ± 15 ms -0.75 %
threejs_development-mode_10x_hmr + exec 777 ms ± 8.8 ms 777 ms ± 10 ms +0.01 %
threejs_production-mode_10x + exec 4.95 s ± 33 ms 4.98 s ± 24 ms +0.48 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ✅ success
devserver ✅ success

Please sign in to comment.