-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(plugin-module-vue): Add support for *.vue files to modern build --watch #5714
Open
Lakphy
wants to merge
4
commits into
web-infra-dev:main
Choose a base branch
from
Lakphy:feat-vue-plugin-watcher
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 65e2654 The changes in this PR will be included in the next version bump. This PR includes changesets to release 257 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original @modern-js/plugin-module-vue plugin will not watch
*.vue
files modifications when runningmodern build --watch
. I added an esbuild plugin that can add*.vue
files to modern.js built-in watcher in the file list.One thing to note is that compiler.addWatchFile requires the compiler object (type:
class EsbuildCompiler implements ICompiler
in EsbuildCompiler declaration). I got the compiler object through config.hooks. The code is as follows:I think this might be unstable. I'm wondering if there is a more stable way to get the compiler object for external plugins?
Thanks!
Related Links
EsbuildCompiler declaration
Checklist
pnpm run change
.