Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency package name to symfony/property-info #576

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

abcang
Copy link
Contributor

@abcang abcang commented Mar 13, 2024

Target branch: 4.8.x
Resolves issue #

  • It is a Bug fix
  • It is a New feature
  • Breaks BC
  • Includes Deprecations

The PropertyInfoExtractor and ReflectionExtractor are included in symfony/property-info.
The symfony/property-info is included in require-dev of symfony/serializer, but not in require. Therefore, if the packages are installed with the --no-dev option, the classes will not be found and an error requiring the installation of the incorrect package will be displayed.

@Spomky Spomky self-assigned this Mar 22, 2024
@Spomky Spomky added the dependencies Pull requests that update a dependency file label Mar 22, 2024
@Spomky Spomky added this to the 4.8.3 milestone Mar 22, 2024
@Spomky Spomky merged commit 174df5a into web-auth:4.8.x Mar 22, 2024
12 of 14 checks passed
@Spomky
Copy link
Contributor

Spomky commented Mar 22, 2024

Many thanks!

@abcang abcang deleted the abcang/fix_dep_package_name branch March 25, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants