Fix spaceing between buttons #3967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Using !important in lots of places can make things hard to customize in the future. Are we sure we need these everywhere? I wonder if we could achieve it with regular CSS specificity logic.
Some docs on the subject: https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity
Love the thorough write up with pics 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3891
What changed?
Set a fixed space between buttons to be
12pxbefore:
after:
before:
after:
before:
after:
before:
after: