Skip to content

Commit

Permalink
Skip linting on nightly (#478)
Browse files Browse the repository at this point in the history
* run linting only on ubuntu

* skip linting on nightly as its already linted code

* Update nightly.yaml

* import auth pkg

* run nightly

* change back nightly to run on main only

Co-authored-by: rokshana-b <[email protected]>
  • Loading branch information
iahmad9 and rokshana-b authored Jul 19, 2021
1 parent 7cf9515 commit fa7e749
Show file tree
Hide file tree
Showing 5 changed files with 14,790 additions and 215 deletions.
28 changes: 2 additions & 26 deletions .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,6 @@ on:

name: Nightly
jobs:
lint:
runs-on: ${{matrix.os}}
strategy:
matrix:
os: [ubuntu-latest, macOS-latest]
steps:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.16.x
- name: Checkout code
uses: actions/checkout@v2
- name: Clean
run: make clean
- name: Dependencies
run: make dependencies
- name: Fake Install flux
run: mkdir -p pkg/flux/bin && touch pkg/flux/bin/flux
- name: Run linters
uses: golangci/golangci-lint-action@v2
with:
version: v1.29
args: --timeout=600s

build:
runs-on: ${{matrix.os}}
strategy:
Expand All @@ -51,7 +27,7 @@ jobs:
path: bin
retention-days: 1
test-eks:
needs: [lint, build]
needs: [build]
runs-on: ${{matrix.os}}
strategy:
matrix:
Expand Down Expand Up @@ -135,7 +111,7 @@ jobs:
ginkgo --reportFile=$(pwd)/test-results/acceptance-test-results.xml -v ./test/acceptance/test/...
if: always()
test-gke:
needs: [lint, build]
needs: [build]
runs-on: ${{matrix.os}}
strategy:
matrix:
Expand Down
4 changes: 1 addition & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/fluxcd/go-git-providers v0.2.0
github.com/fluxcd/helm-controller/api v0.11.1
github.com/fluxcd/kustomize-controller/api v0.13.0
github.com/fluxcd/pkg/apis/meta v0.10.0 // indirect
github.com/fluxcd/pkg/apis/meta v0.10.0
github.com/fluxcd/source-controller/api v0.15.2
github.com/go-git/go-billy/v5 v5.3.1
github.com/go-git/go-git/v5 v5.4.1
Expand All @@ -32,13 +32,11 @@ require (
google.golang.org/grpc v1.38.0
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0
google.golang.org/protobuf v1.27.1
gopkg.in/yaml.v2 v2.4.0
k8s.io/api v0.21.2
k8s.io/apiextensions-apiserver v0.21.2
k8s.io/apimachinery v0.21.2
k8s.io/client-go v0.21.2
sigs.k8s.io/controller-runtime v0.9.1
sigs.k8s.io/controller-tools v0.4.1 // indirect
sigs.k8s.io/yaml v1.2.0

)
Expand Down
Loading

0 comments on commit fa7e749

Please sign in to comment.