Skip to content

Commit

Permalink
Merge pull request #136 from weaveworks/create-sources-adr
Browse files Browse the repository at this point in the history
docs: Add ADR for creating sources
  • Loading branch information
yiannistri authored Nov 8, 2023
2 parents a8b1deb + 70864a7 commit f576348
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ This is for tracking weaveworks internal information on weave-gitops. Will inclu
- [20. Explorer Monitoring](docs/adrs/0020-explorer-monitoring.md)
- [21. Query Scaling Implementation Decisions](docs/adrs/0021-query-scaling-implementation-decisions.md)
- [22. Explorer Collector Deletion Detection](docs/adrs/0022-explorer-collector-deletion-detection.md)
- [23. Create Sources from the UI](docs/adrs/0023-create-sources-from-the-ui.md)

<!-- /ADRS -->

Expand Down
24 changes: 24 additions & 0 deletions docs/adrs/0023-create-sources-from-the-ui.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# 23. Create Flux sources from the UI

Date: 2023-11-06

## Status

Accepted

## Context

Weave GitOps Enterprise (WGE) does not currently support the creation of Flux sources (GitRepository, HelmRepository, OCIRepository etc.) through the UI.

## Decision

We will enable the creation of Flux sources in the WGE UI by replicating the functionality offered by the [Flux CLI](https://fluxcd.io/flux/cmd/flux_create_source/).

This means that the UI will make no attempt to additionally create secrets that are referenced by the Flux sources being created. Instead, the user will be asked to enter the name of a secret in the Create source UI form, that the source will reference.


## Consequences

The decision to forgo secret creation means that users that create sources that reference secrets, will need to create those secrets prior to creating a source that relies on them. Although this is not an ideal workflow, it is still worth doing for the following reasons:
- Not all sources will be referencing secrets, examples of such sources are public Helm repositories of popular tools or when workload identity is configured.
- The proposed solution does not preclude us from enhancing this feature later to also create secrets (possibly via the use of ExternalSecrets)

0 comments on commit f576348

Please sign in to comment.