Skip to content

Commit

Permalink
Enforce a min_refresh_duration
Browse files Browse the repository at this point in the history
Before this change a refresh of peers is run on a variety of scenarios--
including any time there is a topology change. In a moderately sized
cluster (200+ nodes) there is basically *always* a topology change
(connections closing, opening, etc.). Because of this constant state of
topology change the mesh ends up constantly updating the peer set
effectively in a loop.

This patch simply ensures that the refresh happens no more frequently
than initialInterval (2s) to avoid this CPU spinning.
  • Loading branch information
jacksontj committed Aug 21, 2019
1 parent b7aea39 commit c0bf354
Showing 1 changed file with 31 additions and 2 deletions.
33 changes: 31 additions & 2 deletions connection_maker.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,37 @@ func (cm *connectionMaker) refresh() {
}

func (cm *connectionMaker) queryLoop(actionChan <-chan connectionMakerAction) {
timer := time.NewTimer(maxDuration)
run := func() { timer.Reset(cm.checkStateAndAttemptConnections()) }
currentDuration := maxDuration
lastRun := time.Time{}
timer := time.NewTimer(currentDuration)

resetTimer := func(d time.Duration) {
if !timer.Stop() {
select {
case <-timer.C:
default:
}
}

currentDuration = d
timer.Reset(currentDuration)
}

run := func() {
now := time.Now()

// If run() was called too recently, we want to ensure that the duration
// is no longer than initialInterval
if now.Sub(lastRun) < initialInterval {
if currentDuration > initialInterval {
resetTimer(initialInterval)
}
} else {
// otherwise this means we hit the timer
resetTimer(cm.checkStateAndAttemptConnections())
lastRun = now
}
}
for {
select {
case action := <-actionChan:
Expand Down

0 comments on commit c0bf354

Please sign in to comment.