add : first five section #1
Conversation
| </header> | ||
| <main> | ||
| <div class="container"> | ||
| <img class="container_img" src="images/man.png" alt="person image"> |
There was a problem hiding this comment.
@sandesh9988 Should this image tag be within a figure tag?
| <div class="container"> | ||
| <img class="container_img" src="images/man.png" alt="person image"> | ||
| <!--<button class="container_playbtn"></button> --> | ||
| <img class="container_playbtn" src="images/play.png" alt="play button"> |
There was a problem hiding this comment.
@sandesh9988
If this is a play button, why do we need an image? Can we construct this with CSS? What about using SVG?
Also think about hover effects.
| <p>Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore <br>magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd <br>gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing<br> elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore</p> | ||
| </div> | ||
| <div class="box"> | ||
| <div class="boxleft"> |
There was a problem hiding this comment.
box bhitra boxleft and boxright rakhney ki box__left?
| <div class="box"> | ||
| <div class="boxleft"> | ||
| <h3>Our mission</h3> | ||
| <p class="box_desc1">Lorem ipsum dolor sit amet consectetur adipisicing <br>elit. Consectetur, delectus. Vitae odit commodi <br>reiciendis mollitia ratione nostrum repellendus <br>dignissimos, rem id. Officiis harum iste quibusdam !</p> |
There was a problem hiding this comment.
WYSIWYG bhitra aaune content haru, jastai ki paragraph, list, and so on ma class use garnu hudaina, kina ki these type of content is auto-generated from backend.
Class add bhayera aaudaina.
- Class names haru "box_button1" is the wrong way. Should be just button.
Ekchoti feri BEM hera.
| color: black; | ||
| text-decoration: none; | ||
| position: relative; | ||
| left: 320px; |
There was a problem hiding this comment.
@sandesh9988 Is there a better way to style this without defining left:320px?
| position: relative; | ||
| display: flex; | ||
| color: white; | ||
| background-color: #F0564B; |
There was a problem hiding this comment.
Don't define the colors explicitly. You should name them in config file and use variables instead.
| } | ||
| .second_button{ | ||
| position: relative; | ||
| display: flex; |
There was a problem hiding this comment.
@sandesh9988 If you've declared flex, declare the flex-wrap too. This helps in cross-browser support.
|
|
||
| position: absolute; | ||
| font-family: "Inter"; | ||
| margin-top: 180px; |
There was a problem hiding this comment.
@sandesh9988 Again, margin-top: 180px, right: 300px bhanda pani yeslai flex, margin auto or aru kunai tarika le align garna try gara. Yetro dherai units px ma lekhyo bhaney responsive garna ekdum garo hunchha.
| display: flex; | ||
| color: black; | ||
| background-color: white; | ||
| border-color: #F0564B; |
There was a problem hiding this comment.
@sandesh9988 again, color should not be defined explicitly.
| box-sizing: border-box ; | ||
| } | ||
| .container{ | ||
| position: relative; |
There was a problem hiding this comment.
@sandesh9988 Style.scss khali chodnu parcha.
Create files for everything you want to write ani tesma lekha. Style.scss ma sake samma kei nalekha.
Example: https://github.com/bishaller/jug
No description provided.