Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace "@react-navigation/native-stack" with "@react-navigation/stack" #151

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Saadnajmi
Copy link
Contributor

@Saadnajmi Saadnajmi commented Oct 16, 2024

This change is split out from #123. Native stack does not compile for macOS, sadly. To help add support for macOS and potentially other platforms in the future, let's replace Native Stack with the JS based Stack.

@wcandillon wcandillon self-requested a review October 16, 2024 18:27
Copy link
Owner

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable change :)

@wcandillon wcandillon merged commit dd0f486 into wcandillon:main Oct 17, 2024
5 checks passed
@Saadnajmi Saadnajmi deleted the stack branch October 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants