fix(🐯): fix minor parameter bug in drawSvg() (Shopify#2811)

undefined values for with and weight weren't accepted.
wcandillon · Dec 16, 2024 · bd526a5 · bd526a5
1 parent 7511466
commit bd526a5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/skia/cpp/api/JsiSkCanvas.h b/packages/skia/cpp/api/JsiSkCanvas.h
@@ -377,7 +377,7 @@ class JsiSkCanvas : public JsiSkHostObject {
 
   JSI_HOST_FUNCTION(drawSvg) {
     auto svgdom = JsiSkSVG::fromValue(runtime, arguments[0]);
-    if (count == 3) {
+    if (count == 3 && arguments[1].isNumber() && arguments[2].isNumber()) {
       // read size
       auto w = arguments[1].asNumber();
       auto h = arguments[2].asNumber();