chore(👷): remove unused namespace (Shopify#2797)

wcandillon · Dec 8, 2024 · 4073bb4 · 4073bb4
1 parent 52f2e44
commit 4073bb4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/packages/skia/android/cpp/rnskia-android/RNSkAndroidPlatformContext.h b/packages/skia/android/cpp/rnskia-android/RNSkAndroidPlatformContext.h
@@ -1,6 +1,5 @@
 #pragma once
 
-// TODO: Add android flags
 #if __ANDROID_API__ >= 26
 #include <android/hardware_buffer.h>
 #endif
@@ -28,7 +27,6 @@
 #pragma clang diagnostic pop
 
 namespace RNSkia {
-namespace jsi = facebook::jsi;
 
 class RNSkAndroidPlatformContext : public RNSkPlatformContext {
 public:
@@ -178,16 +176,16 @@ class RNSkAndroidPlatformContext : public RNSkPlatformContext {
     if (!SkImages::GetBackendTextureFromImage(image, &texture, true)) {
       throw std::runtime_error("Couldn't get backend texture from image.");
     }
-    return getJSITextureInfo(texture);
+    return getTextureInfo(texture);
   }
 
   const TextureInfo getTexture(sk_sp<SkSurface> surface) override {
     GrBackendTexture texture = SkSurfaces::GetBackendTexture(
         surface.get(), SkSurface::BackendHandleAccess::kFlushRead);
-    return getJSITextureInfo(texture);
+    return getTextureInfo(texture);
   }
 
-  static const TextureInfo getJSITextureInfo(const GrBackendTexture &texture) {
+  static const TextureInfo getTextureInfo(const GrBackendTexture &texture) {
     if (!texture.isValid()) {
       throw std::runtime_error("invalid backend texture");
     }

diff --git a/packages/skia/cpp/rnskia/RNSkPlatformContext.h b/packages/skia/cpp/rnskia/RNSkPlatformContext.h
@@ -27,7 +27,6 @@
 
 namespace RNSkia {
 
-namespace jsi = facebook::jsi;
 namespace react = facebook::react;
 
 struct TextureInfo {

diff --git a/packages/skia/ios/RNSkia-iOS/RNSkiOSPlatformContext.h b/packages/skia/ios/RNSkia-iOS/RNSkiOSPlatformContext.h
@@ -10,8 +10,6 @@
 #include "RNSkPlatformContext.h"
 #include "ViewScreenshotService.h"
 
-#include <jsi/jsi.h>
-
 namespace facebook {
 namespace react {
 class CallInvoker;
@@ -20,8 +18,6 @@ class CallInvoker;
 
 namespace RNSkia {
 
-namespace jsi = facebook::jsi;
-
 class RNSkiOSPlatformContext : public RNSkPlatformContext {
 public:
   RNSkiOSPlatformContext(