Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crollow #6061

Merged
merged 3 commits into from
Jan 19, 2017
Merged

Add crollow #6061

merged 3 commits into from
Jan 19, 2017

Conversation

purefan
Copy link
Contributor

@purefan purefan commented Jan 11, 2017

Source at: https://github.com/purefan/crollow
v1.0.0

Checklist:

  • Used tags: true
  • Ran the tests

@FichteFoll
Copy link
Collaborator

Report for crollow

Repository checks

No failures

No warnings

Package checks

Reporting 4 failures:

  • '.sublime-workspace' files contain session data and should never be submitted to version control
    File: crollow.sublime-workspace
  • The binding ['ctrl+shift+l'] unconditionally overrides a default binding
    File: Default (Windows).sublime-keymap
  • The binding ['ctrl+shift+l'] unconditionally overrides a default binding
    File: Default (Linux).sublime-keymap
  • The binding ['super+shift+l'] unconditionally overrides a default binding
    File: Default (OSX).sublime-keymap

No warnings

For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/package_reviewer/wiki

@math2001
Copy link
Contributor

Just a little GitHub's markdown tip:

[Y] Used tags: true
[Y] Ran the tests

- [x] lorem
- [ ] ipsum

does this:

[Y] Used tags: true
[Y] Ran the tests

  • lorem
  • ipsum

@FichteFoll
Copy link
Collaborator

You haven't pushed a new tag with your changes yet.

@math2001
Copy link
Contributor

You can remove this in your c.json: "platforms": ["osx", "windows", "linux"]

@FichteFoll
Copy link
Collaborator

FichteFoll commented Jan 18, 2017

@math2001 I stopped asking PR authors to do that since we can easily batch-remove them with all the other default values that people provide (readme, issues, author), should we ever get to do that. See also #4310.

@math2001
Copy link
Contributor

So, has that formater been written yet? But thanks for the info & initiative 👍

@FichteFoll
Copy link
Collaborator

No, otherwise that issue would have mentioned it and it would be included somewhere in this repo.

@purefan
Copy link
Contributor Author

purefan commented Jan 19, 2017

@FichteFoll You're right of course, I've done it now

Source at: https://github.com/purefan/crollow
v1.0.1

Checklist:

  • Used tags: true
  • Ran the tests
  • Fixed errors from comments

@FichteFoll FichteFoll merged commit df36d39 into wbond:master Jan 19, 2017
taylorzane pushed a commit to adelyte/package_control_channel that referenced this pull request Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants