-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a formatter utility #4310
Comments
Seems reasonable... are contributors going to be the ones required to run this tool after making any changes or adding a plugin? Not sure we want to make that process any more difficult for newcomers. |
No, I don't think we can reasonably require package authors to run it, but it will be a part of the ChannelRepositoryTools package so that they can do it optionally. There doesn't seem to be a reasonable way to include this in the travis ci build either. |
For Travis CI, we might be able to run the formatter then diff to see if there are changes/not. If there are changes (i.e. formatter wasn't run since last commit), then we could complain and exit with a non-zero code. |
@twolfson +1 |
Some of the formatter features have been added as tests in #7853, so the user can fix the issue by themselves. |
Better idea: We can have a github action run the formatter on pull requests and push to the branch when there are changes and run the tests afterwards, also via actions instead of travis. |
The formatter should:
details
, notablyreadme
,author
,base
platforms
(also"platforms": ["windows", "linux", "osx"]
)example-repository.json
uses, which is:labels
,author
andplatforms
keysname
key for github repos if none present? We could make this a soft requirement in the process.platforms
values into a list?More?
The text was updated successfully, but these errors were encountered: