refactor: move send_command macro into a function
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro accepts expressions with the same datatype in all invocations. Moving it into a function helps language servers make inferences easier because the expressions become concrete types.
|
CC: @zubairmh |
zubairmh
approved these changes
Apr 1, 2024
|
I've tested the PR, we can get this merged |
|
@Shinyzenith ping |
Shinyzenith
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
send_commandmacro in SWHKD'sdaemon.rscomponent accepts expressions with the same datatype in all invocations. Moving it into a function helps language servers like Rust Analyzer make inferences easier because the expressions become concrete types.