NestedFuture: new wart to avoid nested futures #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianhjr-dealengine
force-pushed
the
impl-neste-future-wart
branch
from
c6cfe7e
to
feccb56
Compare
core/src/main/scala-2/org/wartremover/contrib/warts/NestedFuture.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala-3/org/wartremover/contrib/warts/NestedFuture.scala
Outdated
Show resolved
Hide resolved
fabianhjr-dealengine
force-pushed
the
impl-neste-future-wart
branch
3 times, most recently
from
a6a7895
to
599aeec
Compare
|
Ran scalafmt, apologies for the dud. https://github.com/wartremover/wartremover-contrib/actions/runs/7402489095/job/20142818182 |
fabianhjr-dealengine
force-pushed
the
impl-neste-future-wart
branch
2 times, most recently
from
dc215f0
to
05a21df
Compare
|
Hi @xuwei-k, scalafmtf and rebased. |
Co-authored-by: Iván Molina Rebolledo <[email protected]>
fabianhjr-dealengine
force-pushed
the
impl-neste-future-wart
branch
from
05a21df
to
b1de43e
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has bitten a few people at workplace.
Scala 3 impl is lacking twitter future support.
Pending: