Provide a project's users via the JSON API

Closes pypi#16999
warsaw · Oct 30, 2024 · 694043d · 694043d
1 parent 4ae96f9
commit 694043d
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 3 deletions.
diff --git a/tests/unit/legacy/api/test_json.py b/tests/unit/legacy/api/test_json.py
@@ -26,6 +26,7 @@
     JournalEntryFactory,
     ProjectFactory,
     ReleaseFactory,
+    RoleFactory,
 )
 
 
@@ -210,7 +211,9 @@ def test_renders(self, pyramid_config, db_request, db_session):
             )
             for r in releases[1:]
         ]
-        user = UserFactory.create()
+        user = UserFactory.create(username="guido")
+        RoleFactory.create(user=user, project=project)
+
         JournalEntryFactory.reset_sequence()
         je = JournalEntryFactory.create(name=project.name, submitted_by=user)
 
@@ -260,6 +263,7 @@ def test_renders(self, pyramid_config, db_request, db_session):
                 "requires_dist": None,
                 "requires_python": None,
                 "summary": None,
+                "users": ["guido"],
                 "yanked": False,
                 "yanked_reason": None,
                 "version": "3.0",
@@ -533,7 +537,14 @@ def test_detail_renders(self, pyramid_config, db_request, db_session):
             )
             for r in releases[1:]
         ]
-        user = UserFactory.create()
+
+        user = UserFactory.create(username="guido")
+        RoleFactory.create(user=user, project=project)
+        RoleFactory.create(user=UserFactory.create(username="dstufft"), project=project)
+        RoleFactory.create(
+            user=UserFactory.create(username="ewdurbin"), project=project
+        )
+
         JournalEntryFactory.reset_sequence()
         je = JournalEntryFactory.create(name=project.name, submitted_by=user)
 
@@ -584,6 +595,7 @@ def test_detail_renders(self, pyramid_config, db_request, db_session):
                 "requires_dist": None,
                 "requires_python": None,
                 "summary": None,
+                "users": ["dstufft", "ewdurbin", "guido"],
                 "yanked": False,
                 "yanked_reason": None,
                 "version": "3.0",
@@ -625,7 +637,12 @@ def test_minimal_renders(self, pyramid_config, db_request):
             size=200,
         )
 
-        user = UserFactory.create()
+        user = UserFactory.create(username="dstufft")
+        RoleFactory.create(user=user, project=project)
+        RoleFactory.create(
+            user=UserFactory.create(username="ewdurbin"), project=project
+        )
+
         JournalEntryFactory.reset_sequence()
         je = JournalEntryFactory.create(name=project.name, submitted_by=user)
 
@@ -676,6 +693,7 @@ def test_minimal_renders(self, pyramid_config, db_request):
                 "requires_dist": None,
                 "requires_python": None,
                 "summary": None,
+                "users": ["dstufft", "ewdurbin"],
                 "yanked": False,
                 "yanked_reason": None,
                 "version": "0.1",

diff --git a/warehouse/legacy/api/json.py b/warehouse/legacy/api/json.py
@@ -25,6 +25,8 @@
     Project,
     Release,
     ReleaseURL,
+    Role,
+    User,
 )
 from warehouse.utils.cors import _CORS_HEADERS
 
@@ -65,6 +67,19 @@ def _json_data(request, project, release, *, all_releases):
         .filter(Release.project == project)
     )
 
+    # Get all of the maintainers for this project.
+    maintainers = [
+        r.user
+        for r in (
+            request.db.query(Role)
+            .join(User)
+            .filter(Role.project == project)
+            .distinct(User.username)
+            .order_by(User.username)
+            .all()
+        )
+    ]
+
     # If we're not looking for all_releases, then we'll filter this further
     # to just this release.
     if not all_releases:
@@ -158,6 +173,7 @@ def _json_data(request, project, release, *, all_releases):
             "author_email": release.author_email,
             "maintainer": release.maintainer,
             "maintainer_email": release.maintainer_email,
+            "users": sorted(user.username for user in maintainers),
             "requires_python": release.requires_python,
             "platform": release.platform,
             "downloads": {"last_day": -1, "last_week": -1, "last_month": -1},