migrate from moment to date-fns #988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that sonar has failed because of SONAR_TOKEN env variable missing, it seems that error not related to PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last years there are some alternatives to momentjs appeared. Like date-fns. Mostly they depend on new itnl, that is build in into all modern browsers.
Unfortunately, I wasn't able to build the project (I've never touched rust before, and the current cargo version refused to accept configs from repo).
That's why I'm not sure that this PR actually works :(
If somebody can check, that it builds correctly now - it would be nice to move to less size costly solution like date-fns.