-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Merging css-docs > tech-docs #192
Conversation
import ThemeContainer from '../ThemeContainer.vue'; | ||
import ThemeSwitcher from '../ThemeSwitcher.vue'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ThemeContainer and ThemeSwitcher doing roughly the same thing by any chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it seems, yes... almost. 😅
...the only big difference is that the ThemeContainer has a slot for content and ThemeSwitcher is only the switch. 😄
But I can look in to if it is possible to combine these in to one. You could just use the ThemeContainer without slotted content to get only the switch. There is also some styling that is different...
import QrColorTable from '../qr-color-table.vue'; | ||
import WidthController from '../WidthController.vue'; | ||
import Box from '../Box.vue'; | ||
import { IconStarFull32 } from '@warp-ds/icons/vue'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but maybe we can use just that one icon here instead of pulling in the whole icons/vue package, like so:
import IconStarFull32 from '@warp-ds/icons/vue/star-full-32';
@@ -126,6 +145,262 @@ export default defineConfig({ | |||
{ text: 'Designers guide', link: '/migration/designers/' }, | |||
], | |||
}, | |||
{ | |||
text: 'Classes', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: typo Co-authored-by: Balbina K <[email protected]>
Sets up for merging the content of css-docs into tech-docs.