Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update & align unocss dependencies #148

Merged
merged 3 commits into from Aug 17, 2023
Merged

fix: update & align unocss dependencies #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8905df
fix: align '@unocss/core' and 'unocss' versions to fix missing Counta…
BalbinaK Aug 16, 2023
04b5d0b
chore(resets.js): fetch resets.css instead of a deprecated resets.min…
BalbinaK Aug 16, 2023
78bdde0
chore: downgrade @unocss/preset-mini to 0.52.7 to keep tests in tact
BalbinaK Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Expand Up @@ -37,26 +37,26 @@
"author": "@djh",
"license": "Apache-2.0",
"dependencies": {
"@unocss/core": "^0.50.6",
"@unocss/preset-mini": "^0.50.6"
"@unocss/core": "^0.55.1",
"@unocss/preset-mini": "^0.52.7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency has to be at 0.52.7 for now.
In 0.53.0 pseudo variants generation order changes.
That causes changes to css order for classes that control the same CSS properties,
which results in bugs in our components (e.g. Button disabled gets a non-disabled text color).
Before we update this package, we should change the way we assign utility classes to components
when they control the same CSS properties.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, here's the ticket to do that btw: https://nmp-jira.atlassian.net/browse/WARP-231

},
"devDependencies": {
"@rollup/plugin-node-resolve": "^15.0.1",
"@semantic-release/changelog": "^6.0.2",
"@semantic-release/git": "^10.0.1",
"@unocss/autocomplete": "^0.50.6",
"@unocss/autocomplete": "^0.55.1",
"@warp-ds/eslint-config": "^0.0.1",
"cz-conventional-changelog": "^3.3.0",
"eslint": "^8.36.0",
"rollup": "^3.19.1",
"semantic-release": "^20.1.1",
"unocss": "^0.50.6",
"unocss": "^0.55.1",
"uvu": "^0.5.6",
"vite": "^4.2.0",
"vitest": "^0.29.3"
},
"peerDependencies": {
"@warp-ds/css": "^1.0.0-alpha.33"
"@warp-ds/css": "^1.0.0-alpha.37"
},
"eslintConfig": {
"extends": "@warp-ds"
Expand Down