Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weave_query): propgate tags on mapped run ops during gql key propagation #3386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions weave_query/weave_query/propagate_gql_keys.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ def _propagate_gql_keys_for_node(
raise ValueError('GQL key function returned "Invalid" type')

if is_mapped:
# Handle tag propagation for mapped run ops
if opdef_util.should_tag_op_def_outputs(opdef.derived_from):
new_output_type = tagged_value_type.TaggedValueType(
types.TypedDict({first_arg_name: unwrapped_input_type}), new_output_type
)
new_output_type = types.List(new_output_type)

# now we rewrap the types to propagate the tags
Expand Down
Loading