Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(weave): Support creating a dataset from ops #3385

Open
wants to merge 11 commits into
base: andrew/ds-frame
Choose a base branch
from
Open

feat(weave): Support creating a dataset from ops #3385

wants to merge 11 commits into from
+184 −3

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Jan 13, 2025 •
edited
Loading

@andrewtruong andrewtruong changed the base branch from master to andrew/ds-frame January 13, 2025 06:08
@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 13, 2025 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=c04f5d15f4fda6a3f50ba436761ae25e822e7449

@andrewtruong andrewtruong changed the title chore(weave): Support creating a dataset from ops feat(weave): Support creating a dataset from ops Jan 13, 2025
@andrewtruong andrewtruong marked this pull request as ready for review January 13, 2025 14:46
@andrewtruong andrewtruong requested a review from a team as a code owner January 13, 2025 14:46
@andrewtruong andrewtruong requested a review from a team as a code owner January 13, 2025 17:51
@mdlinville mdlinville requested a review from J2-D2-3PO January 13, 2025 23:03
tssweeney
tssweeney reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do this? Is this in response to a customer/user? Seems like unnecessary sugar - makes a 1 liner from a 2 liner.

@andrewtruong
Copy link
Collaborator Author

It's just sugar for expressing the user intent "How do I make a dataset of my function's calls" (as per: https://www.notion.so/Eval-and-Dataset-Workflow-API-Improvements-15fe2f5c7ef380c3a89ce031c36cb767?pvs=4#160e2f5c7ef380e7adf5d02da9390c7f)

I'm not against skipping this one

@tssweeney
Copy link
Collaborator

It's just sugar for expressing the user intent "How do I make a dataset of my function's calls" (as per: https://www.notion.so/Eval-and-Dataset-Workflow-API-Improvements-15fe2f5c7ef380c3a89ce031c36cb767?pvs=4#160e2f5c7ef380e7adf5d02da9390c7f)

I'm not against skipping this one

I think it is going to be very rare that you just want to create a dataset from a single op. you almost always are going to filter by something / look for a tag / look for an annotation / filter by a time window / etc... i might opt to skip this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssweeney tssweeney tssweeney left review comments

@J2-D2-3PO J2-D2-3PO Awaiting requested review from J2-D2-3PO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewtruong @tssweeney