Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Enforce stricter typing for generated bindings #3498

Merged
merged 5 commits into from
May 19, 2024

Conversation

fbbdev
Copy link

@fbbdev fbbdev commented May 19, 2024

Description

This PR enforces stricter typing for code output by the new binding generator.

It should fix typechecking problems with TS templates.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

By running unit tests and testing some TS templates manually.

  • Windows
  • macOS
  • Linux

Test Configuration

# System
┌──────────────────────────────────────────────────────────┐
| Name          | MacOS                                    |
| Version       | 12.6.6                                   |
| ID            | 21G646                                   |
| Branding      | Monterey                                 |
| Platform      | darwin                                   |
| Architecture  | amd64                                    |
| Apple Silicon | unknown                                  |
| CPU           | Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz |
| CPU           | Unknown                                  |
| GPU           | Unknown                                  |
| Memory        | Unknown                                  |
└──────────────────────────────────────────────────────────┘

# Build Environment
┌─────────────────────────────────────────────────────────┐
| Wails CLI    | v3.0.0-alpha.4                           |
| Go Version   | go1.22.3                                 |
| Revision     | 02d9bfe0b3e9362863a638429dc5f2242f627fa5 |
| Modified     | false                                    |
| -buildmode   | exe                                      |
| -compiler    | gc                                       |
| CGO_CFLAGS   |                                          |
| CGO_CPPFLAGS |                                          |
| CGO_CXXFLAGS |                                          |
| CGO_ENABLED  | 1                                        |
| CGO_LDFLAGS  |                                          |
| GOAMD64      | v1                                       |
| GOARCH       | amd64                                    |
| GOOS         | darwin                                   |
| vcs          | git                                      |
| vcs.modified | false                                    |
| vcs.revision | 02d9bfe0b3e9362863a638429dc5f2242f627fa5 |
| vcs.time     | 2024-05-08T19:47:46Z                     |
└─────────────────────────────────────────────────────────┘

# Dependencies
┌───────────────────────────┐
| *NSIS           | v3.09   |
| Xcode cli tools | 2395    |
| npm             | 10.5.0  |
└─ * - Optional Dependency ─┘

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@leaanthony leaanthony merged commit 939d22d into wailsapp:v3-alpha May 19, 2024
8 checks passed
@fbbdev fbbdev deleted the fix/bindgen_strict_types branch May 19, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants