Render accessibility checker dialog on left or right edge depending on the userbar position #11819
+95
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://anees-asgharbugfix11540-userba-1syr4.squash.io |
|
Hi @laymonage, if you could spare a moment to take a look at this PR, I'd greatly appreciate your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11540
Description
This bugfix solves the issue of the accessibility checker dialog always being rendered on the right edge of the screen regardless of the position of the user bar.
Details
As part of this fix, the
AccessiblityItemclass now maintains a class propertydialog_position. The position is set to "right" by default and is overwritten ifAccessiblityItemis initialized with the optional new value for dialog position. More here.Screenshots