Add verbose name to Country model #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lb-
commented
Feb 7, 2024
•
lb-
commented
- Supports testing for edge case issues such as #10982 & listing labels
lb-
force-pushed
the
feature/add-verbose-name-country
branch
from
96ff2f7
to
657e1b2
Compare
- Supports testing for edge case issues such as #10982 & listing labels
lb-
force-pushed
the
feature/add-verbose-name-country
branch
from
657e1b2
to
427b57c
Compare
|
Screenshots where this is used for reference 
|
laymonage
reviewed
Feb 8, 2024
Comment on lines
+31
to
32
| verbose_name = "Country of Origin" | ||
| verbose_name_plural = "Countries of Origin" |
There was a problem hiding this comment.
Something that's been bugging me for a while in this project, the verbose names shouldn't be title-cased. We should let Django/Wagtail decide when it needs to be capitalised (e.g. using capfirst()), as per Django's recommendation
Would be nice to have one migration that changes this for all models, or maybe even just edit the old migration files as this doesn't really change anything in the database.
There was a problem hiding this comment.
OK, should we close this PR and I can raise an issue for that global change instead?
There was a problem hiding this comment.
I've made a new PR that includes the above change #485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.