Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 3.12, django 5.0, wagtail 6.1, postgres 12-16, psycopg 3 #40

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

python 3.12, django 5.0, wagtail 6.1, postgres 12-16, psycopg 3 #40

wants to merge 39 commits into from

Conversation

jorenham
Copy link
Contributor

@jorenham jorenham commented Oct 13, 2023 •
edited

... and upgraded gha to use actions/checkout@v4 and actions/setup-python@v5, as the cherry on top

I also took the liberty to drop support for wagtail <3, since this package isn't strictly required there.

Note to self: Django 5.2 will be the first to support Python 3.13

zerolab
zerolab reviewed Oct 13, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jorenham jorenham mentioned this pull request Oct 13, 2023
Closed
@jorenham jorenham requested a review from zerolab October 13, 2023 16:23
@jorenham jorenham changed the title python 3.12, django 4.2, wagtail 5.1, postgres 12-16, psycopg 3 python 3.12, django 5.0, wagtail 5.2, postgres 12-16, psycopg 3 Dec 15, 2023
@jorenham jorenham changed the title python 3.12, django 5.0, wagtail 5.2, postgres 12-16, psycopg 3 python 3.12, django 5.0, wagtail 6.0, postgres 12-16, psycopg 3 Feb 8, 2024
@jorenham
Copy link
Contributor Author

@zerolab It's been a while; would you mind taking another look?
I've been using this fork (succesfully) in production for quite a while now.

@jorenham jorenham changed the title python 3.12, django 5.0, wagtail 6.0, postgres 12-16, psycopg 3 python 3.12, django 5.0, wagtail 6.1, postgres 12-16, psycopg 3 May 24, 2024
zerolab
zerolab approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While my preference would be to bump the min requirements to 5.2 (or at least 4.1) from an LTS point of view, this looks fine.

@cnk as a big wagtail-hallo user, do you have any reservations to this going in?

setup.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorenham @zerolab