Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add CGO_ENABLED=0 to make sure we dont need it #1005

Merged
merged 1 commit into from
Sep 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,23 @@ jobs:
matrix:
include:
- os: ubuntu-latest
goarch: amd64
test_target: test-race
GOARCH: amd64
# race requires cgo, otherwise should not be needed
CGO_ENABLED: 1
# build and test on 32 bit, does not support race
- os: ubuntu-latest
goarch: "386"
test_target: test
GOARCH: "386"
CGO_ENABLED: 0
- os: macos-latest
goarch: amd64
test_target: test
GOARCH: amd64
CGO_ENABLED: 0
- os: windows-latest
goarch: amd64
test_target: test
GOARCH: amd64
CGO_ENABLED: 0
runs-on: ${{ matrix.os }}
steps:
# only run cli binary tests on linux
Expand All @@ -50,5 +55,6 @@ jobs:
go-version: "1.23.0"
- name: Test
env:
GOARCH: ${{ matrix.goarch }}
CGO_ENABLED: ${{ matrix.CGO_ENABLED }}
GOARCH: ${{ matrix.GOARCH }}
run: make ${{ matrix.test_target }}
Loading