Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend grant agreement secret management #2309

Merged
merged 1 commit into from
May 27, 2024

Conversation

Ra33it0
Copy link
Contributor

@Ra33it0 Ra33it0 commented May 22, 2024

Amendment

Upon further evaluation, it turned out that requiring Vault to run a validator adds unnecessary complexity for no real benefit to users that don't already utilize Vault. Effectively, at the moment, Vault would only be used to deliver already existing credentials to a single validator. So even though it would be possible to automatically spin up a Vault cluster alongside the validator, it would neither increase security nor ergonomics of Dotnix. The fact that the validator secrets have to exist unencrypted on the filesystem anyway allows for a simpler implementation where the user can manage secrets using a command line utility with no need for additionally running services.

This does not prevent a future integration with Vault, but creates a base line and a convenient interface for the user.

We already have implemented a succeeding test scenario that provides secrets from Vault to the validator.
This work has been pushed to will be kept for future reference in a separate branch: https://github.com/sporyon/dotnix-core/compare/vault

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label May 22, 2024
@keeganquigley keeganquigley added amendment This PR proposes changes to an existing application. and removed admin-review This application requires a review from an admin. labels May 22, 2024
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the amendment, @Ra33it0. Could you remove the application template content from the pull request body and instead explain what changes this amendment makes and why you want to do them?

@semuelle semuelle self-assigned this May 23, 2024
@keeganquigley keeganquigley added the changes requested The team needs to clarify a few things first. label May 24, 2024
@Ra33it0 Ra33it0 force-pushed the amend-grant-agreement-secret-management branch from 34a6e7f to 3d7106e Compare May 27, 2024 13:33
@github-actions github-actions bot added the admin-review This application requires a review from an admin. label May 27, 2024
@semuelle semuelle added ready for review The project is ready to be reviewed by the committee members. and removed admin-review This application requires a review from an admin. changes requested The team needs to clarify a few things first. labels May 27, 2024
Copy link
Member

@PieWol PieWol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking your time and adjusting the application!

@Noc2 Noc2 merged commit 02b2f3c into w3f:master May 27, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants