Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op mode: T3355: remove the mention of legacy non-image installations #3457

Merged
merged 1 commit into from
May 16, 2024

Conversation

dmbaturin
Copy link
Member

@dmbaturin dmbaturin commented May 15, 2024

We still have a conditional for detecting "legacy non-image installations" in show version. Such installations were never supported by VyOS — that check was only relevant for very old systems upgraded from Vyatta Core instances that were created with install system instead of install image. Even Vyatta Core itself dropped support for that post 6.1 (or so), so such systems certainly don't exist in the wild now.

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): legacy code removal

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

They were never supported by VyOS,
that was just for very old systens upgraded from Vyatta Core
@c-po c-po requested review from a team, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team May 16, 2024 05:14
@c-po
Copy link
Member

c-po commented May 16, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented May 16, 2024

backport sagitta

✅ Backports have been created

@sever-sever sever-sever merged commit 2a07aae into vyos:current May 16, 2024
7 of 8 checks passed
dmbaturin added a commit that referenced this pull request May 16, 2024
op mode: T3355: remove the mention of legacy non-image installations (backport #3457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants