fix: make command run for Windows in shell due to specific behavior o…

…f `Process.start` for Windows [Windows issues of running flutterw](hyiso#19)
vvvictor07 · Apr 10, 2024 · 66a7750 · 66a7750
1 parent dfe70bf
commit 66a7750
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/flutterw/lib/src/shell.dart b/packages/flutterw/lib/src/shell.dart
@@ -9,6 +9,7 @@ Future<int> runFlutter(List<String> arguments) async {
  final process = await Process.start(
  'flutter',
  arguments,
+ runInShell: Platform.isWindows,
  mode: ProcessStartMode.inheritStdio,
  );
  final code = await process.exitCode;
@@ -40,6 +41,7 @@ Future<int> runShells(
  final process = await Process.start(
  cmds.removeAt(0),
  cmds,
+ runInShell: Platform.isWindows,
  mode: isVerbose ? ProcessStartMode.inheritStdio : ProcessStartMode.normal,
  );
  final code = await process.exitCode;

diff --git a/packages/flutterw_build_aar/bin/flutterw_build_aar.dart b/packages/flutterw_build_aar/bin/flutterw_build_aar.dart
@@ -24,7 +24,11 @@ void main(List<String> arguments) async {
  arguments.replaceRange(
  index + 1, index + 2, [pubspec.version!.canonicalizedVersion]);
  }
- final process = await Process.start('flutter', ['build', 'aar', ...arguments],
- mode: ProcessStartMode.inheritStdio);
+ final process = await Process.start(
+ 'flutter',
+ ['build', 'aar', ...arguments],
+ runInShell: Platform.isWindows,
+ mode: ProcessStartMode.inheritStdio,
+ );
  exitCode = await process.exitCode;
 }