Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add side effects to package.json #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

denisx
Copy link

@denisx denisx commented Dec 6, 2024

Add side effects to package.json, help bundlers cut unused code via treeshake. Good with esm, modules, named imports.

@antfu
Copy link
Member

antfu commented Dec 10, 2024

This library does have side-effects 👀

And what's your usage of this library? It will soon be deprecated

@denisx
Copy link
Author

denisx commented Dec 10, 2024

"side effects = false " show it. if we have side effects, we make a list of imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants