Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCalendar): remove background for week view mode #19745

Merged
merged 2 commits into from May 7, 2024

Conversation

SonTT19
Copy link
Contributor

@SonTT19 SonTT19 commented May 3, 2024

Description

fixes #18988
regression 4820347

Markup:

<template>
  <v-app theme="dark">
    <v-container>
      <v-calendar v-model="msg" view-mode="week" :events="events"></v-calendar>
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const events = [
    {
      title: 'First',
      start: new Date('2024-01-22T02:00:00Z'),
      end: new Date('2024-01-22T04:30:00Z'),
      color: 'blue',
    },
    {
      title: 'Second',
      start: new Date('2024-01-23T05:30:00Z'),
      end: new Date('2024-01-23T08:30:00Z'),
      color: 'red',
    },
    {
      title: 'Third',
      start: new Date('2024-01-23T08:30:00Z'),
      end: new Date('2024-01-23T09:30:00Z'),
      color: 'green',
    },
    {
      title: 'Fourth',
      start: new Date('2024-01-24T02:01:00Z'),
      end: new Date('2024-01-24T04:01:00Z'),
      color: 'green',
    },
  ]

  const msg = ref([new Date('2024-01-23T14:30:00Z')])
</script>

@johnleider johnleider force-pushed the master branch 2 times, most recently from 9d2ea6f to 43529fa Compare May 6, 2024 02:31
johnleider
johnleider previously approved these changes May 7, 2024
@johnleider johnleider added this to the v3.6.x milestone May 7, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VCalendar VCalendar labels May 7, 2024
@johnleider johnleider force-pushed the fix/18988-v-calendar-dark-theme-week-view-mode branch from c0b5046 to b2d61c4 Compare May 7, 2024 16:12
@johnleider johnleider merged commit 5a39b60 into master May 7, 2024
12 of 13 checks passed
@johnleider johnleider deleted the fix/18988-v-calendar-dark-theme-week-view-mode branch May 7, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.4.9] V-Calendar: Dark theme on week view-mode doesnt render
2 participants