fix(types): no props typings in js files #13109
Open
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ilanaya
commented
Nov 1, 2023
| computed: { | ||
| test() { | ||
| // @ts-expect-error Invalid typecast if `this.a` is not any | ||
| ;/** @type import('../utils').IsAny<typeof this.a> */ (this.a) |
There was a problem hiding this comment.
If this.a is any this conversion wouldn't result in an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This PR intended to fix an annoying problem that caused no type support for
propsinjsfiles. As it said it ts documentation unspecified types defaults toanywhich caused the wholepropsobject to becomeany.Explicitly specifying the type
unknownin generic should fully fix this problem.References:
Similar PR addressing the same issue but with a bit harder solution
Known
Vue language toolsissues which are closed as upstream because of this bug.vuejs/language-tools#2347
vuejs/language-tools#1537