Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix#12978 shallowRef's return type #12979

Merged
merged 3 commits into from Dec 6, 2023
Merged

fix#12978 shallowRef's return type #12979

merged 3 commits into from Dec 6, 2023

Conversation

simlevesque
Copy link
Contributor

@simlevesque simlevesque commented Mar 7, 2023

close #12978

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

See #12978

@simlevesque
Copy link
Contributor Author

I've added dts-tests.

@yyx990803 yyx990803 merged commit a174c29 into vuejs:main Dec 6, 2023
4 checks passed
@yyx990803
Copy link
Member

I've updated the types to match Vue 3's (by your PR in vuejs/core#7853) - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shallowRef's return type should match ref's
2 participants